Windows CLI Build

Drone Support
1

After extracting the Windows CLI tool from here:

https://github.com/drone/drone-cli/releases/download/v0.8.0/drone_windows_amd64.tar.gz

I extracted it and found it was just “drone”. Running “drone” with that as is wouldn’t work, until I renamed it “drone.exe”, after which it launched.

Shouldn’t the Windows tool automatically be named “drone.exe” inside the tarball instead of just “drone”?

2

I do not have much windows experience, so I would defer to those running windows. If a .exe extension is required, the build script would need to be updated accordingly.

# compile for all architectures
GOOS=linux   GOARCH=amd64 go build -ldflags "-X main.version=${DRONE_TAG##v}" -o release/linux/amd64/drone   github.com/drone/drone-cli/drone
GOOS=linux   GOARCH=arm64 go build -ldflags "-X main.version=${DRONE_TAG##v}" -o release/linux/arm64/drone   github.com/drone/drone-cli/drone
GOOS=linux   GOARCH=arm   go build -ldflags "-X main.version=${DRONE_TAG##v}" -o release/linux/arm/drone     github.com/drone/drone-cli/drone
-GOOS=windows GOARCH=amd64 go build -ldflags "-X main.version=${DRONE_TAG##v}" -o release/windows/amd64/drone github.com/drone/drone-cli/drone
+GOOS=windows GOARCH=amd64 go build -ldflags "-X main.version=${DRONE_TAG##v}" -o release/windows/amd64/drone.exe github.com/drone/drone-cli/drone
GOOS=darwin  GOARCH=amd64 go build -ldflags "-X main.version=${DRONE_TAG##v}" -o release/darwin/amd64/drone  github.com/drone/drone-cli/drone

# tar binary files prior to upload
tar -cvzf release/drone_linux_amd64.tar.gz   -C release/linux/amd64   drone
tar -cvzf release/drone_linux_arm64.tar.gz   -C release/linux/arm64   drone
tar -cvzf release/drone_linux_arm.tar.gz     -C release/linux/arm     drone
-tar -cvzf release/drone_windows_amd64.tar.gz -C release/windows/amd64 drone
+tar -cvzf release/drone_windows_amd64.tar.gz -C release/windows/amd64 drone.exe
3

Yeah, that change looks perfect to me.