Promote from ui

gilesbradshaw · October 1, 2020, 12:01pm

This form doesn’t really work on a mobile device - the fields don’t layout properly. You can’t edit parameters

Also when you restart a promoted build it doesn’t get the previously entered parameters

Also the way the parameters are entered is irritating (imo) (I continually get it wrong anyhow and end up missing out a parameter even though I’ve filled in fields)

Just enter one - and press deploy. There should be no need to click ‘add’ - only click that if you need to enter another

Also it would be good to see the parameters afterwards on the UI

bradrydzewski · October 1, 2020, 2:03pm

Also when you restart a promoted build it doesn’t get the previously entered parameters

this was patched a few months ago. perhaps you are not running the latest version of the software …

github.com

harness/drone/blob/master/handler/api/repos/builds/retry.go#L100

      
        
            		}
            
            
		for key, value := range r.URL.Query() {
            			if key == "access_token" {
            				continue
            			}
            			if key == "debug" {
            				continue
            			}
            			if len(value) == 0 {
            				continue
            			}
            			hook.Params[key] = value[0]
            		}
            		for key, value := range prev.Params {
            			hook.Params[key] = value
            		}
            
            
		result, err := triggerer.Trigger(r.Context(), repo, hook)
            		if err != nil {
            			render.InternalError(w, err)

This form doesn’t really work on a mobile device - the fields don’t layout properly. You can’t edit parameters

yes, looks like there is a minor css overflow issue that can cause problems when you need to enter custom parameters on mobile (see below screenshot). maybe a min-width issue on the form? we will plan to resolve in the next release, however, we welcome community members submitting pull requests to help improve the software and expedite resolving such issues. The source code for the user interface can be found at GitHub - drone/drone-ui: Front-end for the Drone continuous integration server