Having trouble configuring up a DRONE_OPEN=false instance

Drone Support
1

Hi

I’ve just found this project and it is absolutely perfect for what i’m looking for.

I have setup an instance and have connected it to my github account, and have got builds triggering on git hooks.

The issue that i am facing is that the instance doesn’t seem to be closed, and anyone can register. I know this as i have managed to login with my personal github account. This is a bit weird as i’ve been reading the docs and it says that it should be closed by default, and that I add the admins through the yml config.

Here is the docker-compose.yml i’m using, am i missing something obvious?

version: '2'

services:
  drone-server:
    image: drone/drone:0.7
    ports:
      - 80:8000
    volumes:
      - /var/lib/drone:/var/lib/drone/
    restart: always
    environment:
      - DRONE_OPEN=false
      - DRONE_ADMIN=mrceephax
      - DRONE_HOST=${DRONE_HOST}
      - DRONE_GITHUB=true
      - DRONE_GITHUB_CLIENT=${DRONE_GITHUB_CLIENT}
      - DRONE_GITHUB_SECRET=${DRONE_GITHUB_SECRET}
      - DRONE_SECRET=${DRONE_SECRET}
  drone-agent:
    image: drone/drone:0.7
    command: agent
    restart: always
    depends_on:
      - drone-server
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    environment:
      - DRONE_SERVER=ws://drone-server:8000/ws/broker
      - DRONE_SECRET=${DRONE_SECRET}

Any pointers to what i’m doing wrong would be most appreciated.

Thanks

2

You missed environment DRONE_ORGS (http://docs.drone.io/installation/)

services:
  drone-server:
    image: drone/drone:0.7
    environment:
      - DRONE_OPEN= false
+     - DRONE_ORGS=dolores,dogpatch
      - DRONE_ADMIN=johnsmith,janedoe
      - DRONE_GITHUB_CLIENT=${DRONE_GITHUB_CLIENT}
      - DRONE_GITHUB_SECRET=${DRONE_GITHUB_SECRET}
      - DRONE_SECRET=${DRONE_SECRET}
3

Thanks @ozbillwang, totally missed that. Does that mean a guthub organisation is required? Or can I just name what I like in there?

4

I currently use bitbucket cloud. I limit the users with bitbucket groups as well.

From my view, you need to define the Github organisation to limit the users, a real name in Github.