aantono
December 5, 2018, 5:45pm
1
Is the version of Helm Chart for Drone (https://github.com/helm/charts/tree/master/stable/drone ) compatible with the 1.0 release? Is there anything else that has changed besides the version of the docker image, that needs to be overridden with the value properties?
Hey Alex, 1.0-rc.1 is not compatible with the Helm chart yet. Many of the configuration parameters changed and the Helm Chart needs to be updated accordingly once 1.0-final is available.
aantono
December 5, 2018, 7:21pm
3
Do you have a timeline for when that is expected to happen?
regner
December 6, 2018, 3:38am
4
There is an open PR to update the Helm chart. I would recommend following that for updates.
helm:master ← Adaptly:pc-drone-1
opened 01:37AM - 29 Nov 18 UTC
<!--
Thank you for contributing to helm/charts. Before you submit this PR we'd … like to
make sure you are aware of our technical requirements and best practices:
* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
* https://github.com/helm/helm/tree/master/docs/chart_best_practices
For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:
* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.
For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.
Please make sure you test your changes before you push them. Once pushed, a CircleCI
will run across your changes and do some initial checks and linting. These checks run
very quickly. Please check the results. We would like these checks to pass before we
even continue reviewing your changes.
-->
@christian-roggia
#### What this PR does / why we need it:
I've been working on getting drone-1.0.0-rc.1 running on my cluster. I thought I'd share what I've got, make sure it makes sense to folks. Brad has made it clear that options may change before the final 1.0.0 version is released, so this is really an RFC.
#### Special notes for your reviewer:
Version 1.0.0 has quite a few breaking changes. I have removed the unused gpr options, the unusable agent probes. and I've added the optional secrets service. There are three different secrets services, aws, kubernetes, and vault. I have only tested k8s, because I do not have the means to test the others.
It seems like the prometheus scraping, on port 8000, might be a casualty of v1? Perhaps that also needs to be removed?
There's a lot to pore over.
#### Checklist
- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
I would also recommend checking our announcements on Friday. There are going to be some significant improvements announced for running Drone on Kubernetes
regner
December 6, 2018, 5:22am
6
Why! WHY WOULD YOU SAY THAT! I don’t like you… I hate waiting…
On the plus side our usage of Drone is still very early in it’s infancy so this shouldn’t hurt to much.
flah00
December 7, 2018, 2:07am
7
It’s mere hours away… I’m on tenterhooks @bradrydzewski
regner
December 7, 2018, 5:02am
8
Hoping I have something awesome (and new to play with) to wake up.
I would like to propose that the Helm chart only gives the option to run Drone for Kubernetes. Going forward I would like to deprecate support for agents. Kubernetes support is beta right now in Drone, but it is definitely the future
flah00
December 10, 2018, 5:00am
11
New version of my branch is up, it’s agent-less
helm:master ← Adaptly:pc-drone-1
opened 01:37AM - 29 Nov 18 UTC
<!--
Thank you for contributing to helm/charts. Before you submit this PR we'd … like to
make sure you are aware of our technical requirements and best practices:
* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
* https://github.com/helm/helm/tree/master/docs/chart_best_practices
For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:
* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.
For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.
Please make sure you test your changes before you push them. Once pushed, a CircleCI
will run across your changes and do some initial checks and linting. These checks run
very quickly. Please check the results. We would like these checks to pass before we
even continue reviewing your changes.
-->
@christian-roggia
#### What this PR does / why we need it:
I've been working on getting drone-1.0.0-rc.1 running on my cluster. I thought I'd share what I've got, make sure it makes sense to folks. Brad has made it clear that options may change before the final 1.0.0 version is released, so this is really an RFC.
#### Special notes for your reviewer:
Version 1.0.0 has quite a few breaking changes. I have removed the unused gpr options, the unusable agent probes. and I've added the optional secrets service. There are three different secrets services, aws, kubernetes, and vault. I have only tested k8s, because I do not have the means to test the others.
It seems like the prometheus scraping, on port 8000, might be a casualty of v1? Perhaps that also needs to be removed?
There's a lot to pore over.
#### Checklist
- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
regner
December 10, 2018, 6:23am
12
Thanks for your work on that helm chart. I will put some time in this week and see if I can get it deployed to our cluster.
I would expect these changes to greatly simplify the helm chart.