Debug and deploy text missing

umarizulkifli · February 19, 2021, 7:17am

Seems like debug and deploy button text is missing

drone/drone-ui/blob/ac1349fcc19cafd27976f5d04a4acd24558d4e2f/src/views/Build.vue#L23

      
        
                    class="button-restart"
                    @click.native="handleRestart"
                    :disabled="!isCollaborator">
              <span>Restart</span>
              <IconRestart/>
            </Button>
            
            
<Button outline v-if="isBuildFinished(build)"
                    class="button-debug"
                    @click.native="handleDebug"
                    :disabled="!isCollaborator">
              <IconBug/>
            </Button>
            
            
<Button outline v-if="showDeployButton"
                    class="button-promote"
                    @click.native="openDeployModal">
              <IconDeploy/>
            </Button>
            
            
<ButtonConfirm v-if="showCancelButton" outline

github.com

drone/drone-ui/blob/ac1349fcc19cafd27976f5d04a4acd24558d4e2f/src/views/Build.vue#L29

      
        
            
            
<Button outline v-if="isBuildFinished(build)"
                    class="button-debug"
                    @click.native="handleDebug"
                    :disabled="!isCollaborator">
              <IconBug/>
            </Button>
            
            
<Button outline v-if="showDeployButton"
                    class="button-promote"
                    @click.native="openDeployModal">
              <IconDeploy/>
            </Button>
            
            
<ButtonConfirm v-if="showCancelButton" outline
                           @click="handleCancel"
                           :message="`Are you sure to cancel build #${build.number}?`"
                           class="button-cancel">
              <span>Cancel</span>
              <IconCancel/>
            </ButtonConfirm>

Add span element could fix it
<Button outline v-if=“isBuildFinished(build)”
class=“button-debug”
@click.native=“handleDebug”
:disabled="!isCollaborator">
Debug

    <Button outline v-if="showDeployButton"
            class="button-promote"
            @click.native="openDeployModal">
      <span>Deploy</span>
      <IconDeploy/>
    </Button>

bradrydzewski · February 19, 2021, 2:22pm

the debug and deploy buttons are “icon” buttons, which means we only show the icon and we omit the text on purpose.