Cloning failed in Github Deployment

hanjunlee · February 29, 2020, 7:37am

Hi

Thank you for the implementation of Drone.
I have encountered the situation that cloning has failed for the promote event. The error message is as below.

+ git fetch origin +refs/tags/11d8ccc32ed82ba423d341c5ed3c7115ed0b0014:
fatal: Couldn't find remote ref refs/tags/11d8ccc32ed82ba423d341c5ed3c7115ed0b0014

I’m using Drone for the public repository of Github. I hope you reply it.

ashwilliams1 · February 29, 2020, 5:27pm

Hmm, we received and merged a patch to fix this quite a while back …

mreifman · April 7, 2020, 4:20pm

I’ve encountered the issue in the original post that isn’t addressed by that patch.

I’m creating a GitHub deployment where the ref parameter is a SHA, but when Drone parses the deployment webhook it doesn’t seem to take that case into account:

github.com

drone/go-scm/blob/731e51dbb685830bcd259e4a5deb33cb7b906110/scm/driver/github/webhook.go#L386-L391

    
      
          	if tagRE.MatchString(dst.Ref.Name) {
          		dst.Ref.Path = scm.ExpandRef(dst.Ref.Path, "refs/tags/")
          	} else {
          		dst.Ref.Path = scm.ExpandRef(dst.Ref.Path, "refs/heads/")
          	}
          	return dst

Drone prepends refs/tags to the SHA, which causes results in getting the wrong clone type downstream.

This bug looks related:

ashwilliams1 · April 7, 2020, 4:32pm

Thanks for the analysis. Perhaps the payload is different depending on whether or not you are promoting a tag, a commit or a pull request. As a next step, we would kindly as that you provide a sample hook payload that we can use to reproduce. We will create a unit test using the sample payload, which should allow us to patch accordingly.

mreifman · April 8, 2020, 12:19am

Thanks, @ashwilliams1. Here you go: https://github.com/drone/go-scm/pull/59