It sounds like GitHub Enterprise is returning the http url instead of the https url. We see this sometimes when our users install Gitea (a self-hosted GitHub clone). They are usually able to resolve this by updating the BASE_URL setting in Gitea, which tells Gitea its correct url … I am not sure what the equivalent setting is in GitHub enterprise, but I presume they have something similar. Hopefully that helps
So, in order to verify what you are suggesting, I use the Chrome Dev Tools to inspect the Avatar element, and per the screenshot (I replaced my company name obviously, but nothing else) it looks like the correct url for the avatar is there. Infact, I pasted that URL into my browser and it correctly pulled up an avatar. So, I can’t figure out why Drone can’t seem to display it.
what happens if your curl the avatar url from the command line? does the response indicate a redirect is being returned from GHE? I have never seen this before, to be honest, but perhaps your GHE instance is configured to require login to view avatars?
$ curl https://scm.mycompany.com/avatars/u/1506
You are being <a href="https://scm.mycompany.com/login?return_to=https%3A%2F%2Fscm.mycompany.com%2Favatars%2Fu%2F1506">redirected</a>.
So, I take it that avatars normally do not require auth? So, I should touch base with the GHE team and see if they can adjust things for me?
hmm … I have to be honest that I am a bit surprised by their response. We have ~500 organizations using Drone with Github Enterprise and this has never been reported. I also used Drone with Github Enterprise and did not experience any issues with avatars, albeit this was back in 2015. I am going to reach out to one of our customers that is using GHE + SAML to see if they are experiencing issues with avatars.
Yeah, I’m seeing the exact same thing here. Inspecting the element in Drone shows <my-ghe-domain>/avatars/u/<uid>?. Opening this in a browser loads it fine - if I’m logged into GHE. curling it also gives me a redirect response (presumably, it’s redirecting to the login page.
I believe we have GHE connected to LDAP for authentication. Maybe this issue depends on what authentication provider is being used for GHE?
We just published a preview release of Drone 2.0 (Drone 2.0 available for testing) and we added fallback to display your initials if we cannot load the avatar. I know this isn’t a perfect solution, but much better than the “broken image” icon.
I am going to ask one of our developers to go through and make sure we have wired this up everywhere in the application. It may not be wired up on every page yet, but if not, we can have resolved in the next few days.